[ https://issues.apache.org/jira/browse/THRIFT-4151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949684#comment-15949684 ]
ASF GitHub Bot commented on THRIFT-4151: ---------------------------------------- GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1229 THRIFT-4151: disable pthread concurrency analysis code in standard builds You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-4151 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1229.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1229 ---- commit de46b4b4b23f52b7c1c9dc3eacdc56e79d4beedf Author: James E. King, III <jim.k...@simplivity.com> Date: 2017-03-30T19:47:02Z THRIFT-4151: disable pthread concurrency analysis code in standard builds ---- > Thrift Mutex Contention Profiling (pthreads) should be disabled by default > -------------------------------------------------------------------------- > > Key: THRIFT-4151 > URL: https://issues.apache.org/jira/browse/THRIFT-4151 > Project: Thrift > Issue Type: Improvement > Components: C++ - Library > Affects Versions: 0.10.0 > Environment: pthreads > Reporter: James E. King, III > Assignee: James E. King, III > Priority: Minor > > The default behavior for the concurrency::Mutex class (pthread > implementation) is to track concurrency profiling and report to a callback > routine every so often. Given this is in a critical performance section of > code I would recommend that the default should be to keep this code disabled, > and folks can enable it if they want to for their distribution. -- This message was sent by Atlassian JIRA (v6.3.15#6346)