[ 
https://issues.apache.org/jira/browse/THRIFT-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952147#comment-15952147
 ] 

Jens Geyer commented on THRIFT-4152:
------------------------------------

GitHub user gadLinux opened a pull request:

    https://github.com/apache/thrift/pull/1230

    Make a patch to fix #4152 at least for structs

    Change type Type_ for Struct_ so structs are correctly linked.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gadLinux/thrift THRIFT-4152

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1230
    
----
commit 83ea476613868e78da6196e456583128b9454d00
Author: Gonzalo Aguilar Delgado <gagui...@level2crm.com>
Date:   2017-03-31T09:13:04Z

    Make a patch to fix #4152 at least for structs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


> HTML Documentation doesn't link correctly structs
> -------------------------------------------------
>
>                 Key: THRIFT-4152
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4152
>             Project: Thrift
>          Issue Type: Bug
>          Components: HTML - Compiler
>    Affects Versions: 0.10.0
>         Environment: Thrift Master on commit 
> 431732d39e89f1661dc7dddffedb2c5c1e019cc7
>            Reporter: Gonzalo Aguilar
>            Assignee: Gonzalo Aguilar
>            Priority: Minor
>
> We discovered the html documents are not correctly generated because the 
> links of structs are sometimes done as Struct and sometimes as Typedef. 
> None of the Typedef links are working. Mainly because they are Structs in our 
> case and thus no link is performed. 
> We made a patch for structs. but we have to check if it works for the rest of 
> types. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to