Mario Emmenlauer created THRIFT-4158:
----------------------------------------
Summary: minor issue in README-MSYS2.md
Key: THRIFT-4158
URL: https://issues.apache.org/jira/browse/THRIFT-4158
Project: Thrift
Issue Type: Bug
Components: Build Process
Affects Versions: 1.0
Reporter: Mario Emmenlauer
In README-MSYS2.md there are recommended cmake build flags:
{code}
cmake -G"MinGW Makefiles" -DCMAKE_MAKE_PROGRAM=/mingw64/bin/mingw32-make \
-DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc.exe \
-DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++.exe \
-DWITH_BOOSTTHREADS=ON -DWITH_LIBEVENT=OFF \
-DWITH_SHARED_LIB=OFF -DWITH_STATIC_LIB=ON \
-DWITH_JAVA=OFF -DWITH_PYTHON=OFF -DWITH_PERL=OFF \
{code}
However I think they are not really correct, or am I overlooking something?
The options WITH_JAVA, WITH_PYTHON and WITH_PERL should be
BUILD_JAVA, BUILD_PYTHON and BUILD_PERL, respectively. At least
I could not find the WITH_XXX variants in CMakeLists.txt.
The options CMAKE_MAKE_PROGRAM, CMAKE_C_COMPILER and
CMAKE_CXX_COMPILER should be optional and not required. I think
they are rather confusing since these compilers should be the default for
a MINGW build shell.
Finally, the readme recommends to install
{code}
$ pacman -S bison flex openssl openssl-devel \
mingw-w64-x86_64-boost mingw-w64-x86_64-cmake \
mingw-w64-x86_64-toolchain zlib zlib-devel
{code}
The openssl and zlib variants used here are from MSYS2, not MinGW64.
If there is no strong reason to use those, I think its recommended to use
the MinGW46 variants instead:
{code}
$ pacman -S bison flex mingw-w64-x86_64-openssl \
mingw-w64-x86_64-boost mingw-w64-x86_64-cmake \
mingw-w64-x86_64-toolchain mingw-w64-x86_64-zlib
{code}
My suggested options "build for me" so they come with at least a bit
of testing...
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
