[ 
https://issues.apache.org/jira/browse/THRIFT-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955643#comment-15955643
 ] 

James E. King, III commented on THRIFT-4138:
--------------------------------------------

This broke Visual Studio 2010 and Visual Studio 2017.
We currently build in Appveyor with Visual Studio 2015 only to save time.
I'm considering adding Visual Studio 2010 to the list however, based on this 
break.
std::log10(2) is ambiguous for VS2010.  It could be float, double, or long 
double as input and it doesn't seem to want to choose.
I have a fix queued up, just wanted to make you aware.

> Fix remaining undefined behavior invalid vptr casts in C++ library
> ------------------------------------------------------------------
>
>                 Key: THRIFT-4138
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4138
>             Project: Thrift
>          Issue Type: Sub-task
>          Components: C++ - Library
>            Reporter: Jens Geyer
>            Assignee: Jim Apple
>             Fix For: 0.11.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to