[ https://issues.apache.org/jira/browse/THRIFT-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957052#comment-15957052 ]
ASF GitHub Bot commented on THRIFT-3204: ---------------------------------------- Github user jfarrell closed the pull request at: https://github.com/apache/thrift/pull/529 > SimpleServer process loop missed handle some error > -------------------------------------------------- > > Key: THRIFT-3204 > URL: https://issues.apache.org/jira/browse/THRIFT-3204 > Project: Thrift > Issue Type: Bug > Components: Go - Library > Affects Versions: 0.9.2 > Reporter: Jing Wang > Assignee: Jing Wang > Labels: patch > > SimpleServer do not handle all errors returned by processor. > When a error returned by processor.Process methods In SimpleServer's > processRequests, program will omit this error and log nothing to the > programmer if this error is not thrift.TTransportException type. > If a Protocol error happens, the server will close the client connection and > log nothing, > This bug is cause by a wrong "else if" condition. In the if esle condition, > the inside variable "err" will cover the scope of outside "err", and it will > always be "nil", the "else if" condition will never reached -- This message was sent by Atlassian JIRA (v6.3.15#6346)