[ https://issues.apache.org/jira/browse/THRIFT-3627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959949#comment-15959949 ]
ASF GitHub Bot commented on THRIFT-3627: ---------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/thrift/pull/1243 > Missing basic code style consistency of JavaScript. > --------------------------------------------------- > > Key: THRIFT-3627 > URL: https://issues.apache.org/jira/browse/THRIFT-3627 > Project: Thrift > Issue Type: Improvement > Components: JavaScript - Library > Reporter: Kazuki Matsuda > Assignee: James E. King, III > Priority: Minor > Fix For: 0.11.0 > > > E.g.) > * No white space in {code}function(args){// beteween `){`{code} > https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L1497 > * "Double quoted" (not 'single quoted') string litteral > https://github.com/apache/thrift/blob/84cf363eeedf4cc9bb618bb2b1980696b9f6fc9b/lib/js/src/thrift.js#L133 > Those errors can be easily fixed by fixjsstyle. -- This message was sent by Atlassian JIRA (v6.3.15#6346)