[
https://issues.apache.org/jira/browse/THRIFT-4018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15972167#comment-15972167
]
Dan Bravender commented on THRIFT-4018:
---------------------------------------
bq. Based on the title of this ticket, wouldn't it be better to prevent the
ruby server from being able to corrupt the stream on the sending side?
I believe the line of code I added in write_result is happening on the server
(but I could be wrong):
https://github.com/apache/thrift/pull/1179/files#diff-3f78a103bfde10cf9dd3d6e77afa2516R53
> Ruby server can corrupt connections by putting ApplicationException in the
> middle of a response
> -----------------------------------------------------------------------------------------------
>
> Key: THRIFT-4018
> URL: https://issues.apache.org/jira/browse/THRIFT-4018
> Project: Thrift
> Issue Type: Bug
> Components: Ruby - Library
> Affects Versions: 0.9.3
> Reporter: Dan Bravender
>
> # Have a client make a call to a thrift server method that returns an invalid
> value for an enum
> # Have the client make another call to the same method that returns an
> invalid value for an enum
> *Expected*: Thrift server responds with an ApplicationException for both calls
> *Actual*: The thrift server responds with ApplicationException for the first
> call but then further calls can't be parsed by the client because there is
> unexpected data that the client cannot parse
> I discovered this while writing a test case for THRIFT-3781 though it is the
> opposite problem.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
