[ https://issues.apache.org/jira/browse/THRIFT-4176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977811#comment-15977811 ]
ASF GitHub Bot commented on THRIFT-4176: ---------------------------------------- GitHub user allengeorge opened a pull request: https://github.com/apache/thrift/pull/1255 THRIFT-4176: Implement threaded server for Rust Client: rs * Separate TTransport into two constructs: TIoChannel and TTransport * Make TIoChannel and TTransport Send-able types * Remove refcounting where possible * Replace TSimpleServer with a thread-pool based TServer The removal of refcounting was driven by the need to make constructs threadsafe. I'd always known the ref-counting was hacky; this approach pushes the counting/locking into a separate `TIoChannel` concept that can be cloned to simplify the ownership story for all the concepts above. Also, as requested, I didn't *add* a new server type: I replaced the existing one with this threadpool-based version. You can merge this pull request into a Git repository by running: $ git pull https://github.com/allengeorge/thrift thrift-4176 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1255.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1255 ---- commit 0a0592f333ea4c9be64dd83fa7ce6e78c7307567 Author: Allen George <allen.geo...@gmail.com> Date: 2017-01-30T12:15:00Z THRIFT-4176: Implement threaded server for Rust Client: rs * Separate TTransport into two constructs: TIoChannel and TTransport * Make TIoChannel and TTransport Send-able types * Remove refcounting where possible * Replace TSimpleServer with a thread-pool based TServer ---- > Implement a threaded and threadpool server type for Rust > -------------------------------------------------------- > > Key: THRIFT-4176 > URL: https://issues.apache.org/jira/browse/THRIFT-4176 > Project: Thrift > Issue Type: Improvement > Components: Rust - Library > Reporter: Allen George > Assignee: Allen George > > Currently the Rust client library only provides a single-threaded server. Add > both a multi-threaded server and a threadpool-based server and add the > relevant options to the cross-test code as well. -- This message was sent by Atlassian JIRA (v6.3.15#6346)