[ 
https://issues.apache.org/jira/browse/THRIFT-4193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005653#comment-16005653
 ] 

ASF GitHub Bot commented on THRIFT-4193:
----------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/1264


> Lower the default maxReadBufferBytes for non-blocking servers
> -------------------------------------------------------------
>
>                 Key: THRIFT-4193
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4193
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>            Reporter: Roshan George
>            Assignee: Roshan George
>            Priority: Minor
>             Fix For: 0.11.0
>
>
> {{AbstractNonblockingServerArgs}} sets the default maximum read buffer size 
> to {{Long.MAX_VALUE}}. Almost every machine will probably OOME before it 
> succeeds in hitting that maximum. It should have a lower maximum, perhaps 256 
> MB like the maximum frame size in [the cpp 
> implementation|https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/server/TNonblockingServer.h#L128]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to