Github user markerickson-wf commented on the issue: https://github.com/apache/thrift/pull/1269 @allengeorge I think this approach looks pretty good at my first pass. I left a couple of comments, and we'll probably want unit tests around the state transitions to ensure that all paths are covered (setting / unsetting completers, resetting read counters, etc). I'll also ask couple of other devs I know to review (they have done some recent work using framed transports in Dart). Thanks for submitting the PR!
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---