[ 
https://issues.apache.org/jira/browse/THRIFT-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16041566#comment-16041566
 ] 

Jens Geyer commented on THRIFT-4222:
------------------------------------

GitHub user zwass opened a pull request:

    https://github.com/apache/thrift/pull/1284

    Add Golang NewTServerSocketFromAddrTimeout

    Adds the ability to create a new server socket from a non-TCP (eg. Unix 
socket)
    address. Modeled after the existing NewTSocketFromAddrTimeout function.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kolide/thrift server_socket_from_addr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1284.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1284
    
----
commit 891852bb99ce0e280f55ccdb20c5c4be2d14a2ee
Author: Zachary Wasserman <zachwass2...@gmail.com>
Date:   2017-05-31T16:50:12Z

    Add Golang NewTServerSocketFromAddrTimeout
    
    Adds the ability to create a new server socket from a non-TCP (eg. Unix 
socket)
    address. Modeled after the existing NewTSocketFromAddrTimeout function.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


> Support Unix Domain Sockets in Golang TServerSocket
> ---------------------------------------------------
>
>                 Key: THRIFT-4222
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4222
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Library
>            Reporter: Zach Wasserman
>
> The existing API only supports opening TCP sockets. A minor change (in 
> accordance with the existing API for TSocket) allows for use of unix domain 
> sockets.
> This will obviate the need for a library like this 
> (https://github.com/Wang/thrift_unix_domain/blob/master/server_unix_domain.go)
>  which is mostly a copy of the existing code with minor changes to support 
> the domain socket.
> Patch available: https://github.com/apache/thrift/pull/1284



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to