[ 
https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064407#comment-16064407
 ] 

ASF GitHub Bot commented on THRIFT-4236:
----------------------------------------

GitHub user taozle opened a pull request:

    https://github.com/apache/thrift/pull/1298

    THRIFT-4236: Add context support for go server.

    This commit add the context support for thrift server side in go.
    for compatibility, added a use_context option in go's generator option
    to tell compiler whether generated code should support context.
    Added TProcessor2, TProcessorFactory2, TServer2, TMultiplexedProcessor2
    to support ctx as first param.
    
    See: https://issues.apache.org/jira/browse/THRIFT-4236

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/taozle/thrift context

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1298
    
----
commit cf9cdd53a26c71547998714459e1eb89e17476c9
Author: taozle <tao...@zhihu.com>
Date:   2017-06-27T05:46:53Z

    THRIFT-4236: Add context support for go server.
    
    This commit add the context support for thrift server side in go.
    for compatibility, added a use_context option in go's generator option
    to tell compiler whether generated code should support context.
    Added TProcessor2, TProcessorFactory2, TServer2, TMultiplexedProcessor2
    to support ctx as first param.

----


> Support context in go generated code.
> -------------------------------------
>
>                 Key: THRIFT-4236
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4236
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Go - Compiler, Go - Library
>            Reporter: taozle
>
> Since context is widely used in go's community, and there is lots of 
> advantage to use context such as control timeout, carry extra info in one 
> request etc, so is there any plan for this? i just searched the issues but 
> didn't find anything about this.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to