Github user juliengreard commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1293#discussion_r125757042
--- Diff: compiler/cpp/src/thrift/generate/t_py_generator.cc ---
@@ -610,11 +623,22 @@ string t_py_generator::render_const_value(t_type*
type, t_const_value* value) {
return out.str();
}
+/**
+ * Generates the "forward declarations" for python structs.
+ * These are actually full class definitions so that calls to
generate_struct
+ * can add the thrift_spec field. This is needed so that all thrift_spec
+ * definitions are grouped at the end of the file to enable co-recursive
structs.
+ */
+void t_py_generator::generate_forward_declaration(t_struct* tstruct) {
+ generate_py_struct(tstruct, tstruct->is_xception());
+}
+
/**
* Generates a python struct
*/
void t_py_generator::generate_struct(t_struct* tstruct) {
- generate_py_struct(tstruct, false);
+ //generate_py_struct(tstruct, false);
--- End diff --
bad idea to leave commented code - if you really want to leave it there,
leave also a comment explaining why
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
