[ 
https://issues.apache.org/jira/browse/THRIFT-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075577#comment-16075577
 ] 

ASF GitHub Bot commented on THRIFT-2642:
----------------------------------------

Github user econner commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1293#discussion_r125777018
  
    --- Diff: test/py/SerializationTest.py ---
    @@ -285,6 +290,67 @@ def testIntegerLimits(self):
             for value in bad_values:
                 self.assertRaises(Exception, self._serialize, value)
     
    +    def testRecTree(self):
    +        """Ensure recursive tree node can be created."""
    +        children = []
    +        for idx in range(1, 5):
    --- End diff --
    
    This is just a test to ensure you can make a tree with some children.  
There is no limit on the number of recursions (I guess besides the maximum 
allowed by python).


> Recursive structs don't work in python
> --------------------------------------
>
>                 Key: THRIFT-2642
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2642
>             Project: Thrift
>          Issue Type: Bug
>          Components: Python - Compiler, Python - Library
>    Affects Versions: 0.9.2
>            Reporter: Igor Kostenko
>            Assignee: Eric Conner
>
> Recursive structs in 0.9.2 work fine in c++ & c#, but not in python, because 
> generated code trying to use objects which not constructed yet.
> Struct:
> {code}
> struct Recursive {
> 1: list<Recursive> Children
> }
> {code}
> Python code:
> {code}
> class Recursive:
>   thrift_spec = (
>     None, # 0
>     (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
>   )
> {code}
> Error message:
> {code}
> Traceback (most recent call last):
>   File "ttypes.py", line 20, in <module>
>     class Recursive:
>   File "ttypes.py", line 28, in Recursive
>     (1, TType.LIST, 'Children', (TType.STRUCT,(Recursive, 
> Recursive.thrift_spec)), None, ), # 1
> NameError: name 'Recursive' is not defined
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to