[
https://issues.apache.org/jira/browse/THRIFT-4236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16094403#comment-16094403
]
ASF GitHub Bot commented on THRIFT-4236:
----------------------------------------
GitHub user taozle reopened a pull request:
https://github.com/apache/thrift/pull/1309
Use build tags to support context.
As the comment in https://issues.apache.org/jira/browse/THRIFT-4236, this
PR use build tags to support context in go1.7 above.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/taozle/thrift context
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1309.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1309
----
commit 0df5965eb2a35793f19de1b2696e3c4afb6b5132
Author: taozle <[email protected]>
Date: 2017-07-17T16:40:42Z
Use build tags to support context.
commit e610d07370f55314fa674810cee4574006a15238
Author: taozle <[email protected]>
Date: 2017-07-19T15:47:35Z
Use x/net/context to support go<1.7.
commit 3d4eb9a967317cca7ea6f9e668e80fd06e0651ac
Author: taozle <[email protected]>
Date: 2017-07-19T16:13:59Z
Add legacy_context in go generator.
commit fdee27a80401107fc96c7aee7c2f8e14adaa425a
Author: taozle <[email protected]>
Date: 2017-07-19T16:37:29Z
Fix go test dependency.
commit 88d2fc00c2d8c0a3b6f48fbfea42b02fb7c6080c
Author: taozle <[email protected]>
Date: 2017-07-19T17:13:39Z
Fix GOPATH not set.
commit 8d052a6a97b295021277da29dbc87cf73deb3009
Author: taozle <[email protected]>
Date: 2017-07-20T02:51:11Z
Get x/net/context in lib/go.
commit acf418d6f6c0c75afd8ddaa6263f30e1987a6bfc
Author: taozle <[email protected]>
Date: 2017-07-20T06:13:26Z
Fix go tests.
commit 6451d1419747fb5bc011391872d1afdb6d1f3b1e
Author: taozle <[email protected]>
Date: 2017-07-20T08:39:36Z
Fix go tests in /lib/go/test/tests.
----
> Support context in go generated code.
> -------------------------------------
>
> Key: THRIFT-4236
> URL: https://issues.apache.org/jira/browse/THRIFT-4236
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Reporter: taozle
> Assignee: taozle
> Fix For: 0.11.0
>
>
> Since context is widely used in go's community, and there is lots of
> advantage to use context such as control timeout, carry extra info in one
> request etc, so is there any plan for this? i just searched the issues but
> didn't find anything about this.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
