GitHub user davinchia opened a pull request:
https://github.com/apache/thrift/pull/1311
Fix for constant assignments to optional fields in Go.
As per ticket https://issues.apache.org/jira/browse/THRIFT-4253.
As I dug through the code I realised the problem was not only limited to
optional strings, and that the generator was not generating optionals for all
types.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/davinchia/thrift constant-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1311
----
commit de3d3a76bdaf2baa3eab9c6fdd8d3b31e7887f55
Author: Davin Chia Ming Juay <dc...@liveramp.com>
Date: 2017-07-20T08:08:48Z
logging to track path; modified function to pass optional value over
commit f038cc0d6504ecbf30bd13a1daa0f8fc8201fad4
Author: Davin Chia Ming Juay <dc...@liveramp.com>
Date: 2017-07-20T08:53:24Z
fix generation for bool and int constant values
commit 7c58a2555203aac67aec3d81c71dd807def4de59
Author: Davin Chia Ming Juay <dc...@liveramp.com>
Date: 2017-07-20T09:05:06Z
fix for double; make sure int type is precise
commit 04f07888c714415a94121a774d26738eda0b21ac
Author: Davin Chia Ming Juay <dc...@liveramp.com>
Date: 2017-07-20T09:13:30Z
fix for string
commit acd26f0e9e1c0fc47122b9f2a16573ee84fcc67e
Author: Davin Chia Ming Juay <dc...@liveramp.com>
Date: 2017-07-20T09:24:30Z
remove binary from opt because it is not needed
commit 54e97c3fc09737a15380d82d9cd5a9ac049d9095
Author: Davin Chia Ming Juay <dc...@liveramp.com>
Date: 2017-07-20T20:23:05Z
remove logging
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
