[
https://issues.apache.org/jira/browse/THRIFT-2221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115459#comment-16115459
]
ASF GitHub Bot commented on THRIFT-2221:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1328
THRIFT-2221: detect C++11 and use std namespace for memory operations
(smart_ptr)
I had to close my older pull request because the history got tainted, so I
am reopening it with the suggestions from Jira.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-2221
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1328.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1328
----
commit 95f90ecde41fd60e99779c472a24480a39672060
Author: James E. King, III <[email protected]>
Date: 2017-08-05T16:23:54Z
THRIFT-2221: detect C++11 and use std namespace for memory operations
(smart_ptr)
----
> Generate c++ code with std::shared_ptr instead of boost::shared_ptr.
> --------------------------------------------------------------------
>
> Key: THRIFT-2221
> URL: https://issues.apache.org/jira/browse/THRIFT-2221
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Compiler
> Affects Versions: 0.9.1
> Environment: C++11 compilers with std::shared_ptr support
> Reporter: Chris Stylianou
> Assignee: James E. King, III
> Labels: c++11, compiler, thrift
>
> Most modern compilers now have full support for std::shared_ptr when enable
> with c++11 flags. It would be nice to have the option to generate code that
> uses this instead of boost::shared_ptr. This would enable us to remove
> another boost dependency, on the road to a dependency-free thrift library :)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
