[
https://issues.apache.org/jira/browse/THRIFT-4285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16132000#comment-16132000
]
Chris Bannister edited comment on THRIFT-4285 at 8/18/17 10:05 AM:
-------------------------------------------------------------------
Fix typo, use tmp names for args/results incase the service defines the
argument name as 'args' or 'result'.
This doesn't work with the read_write_private option as the type no longer
implement TStruct, not sure what the use of that flag is given the rest of the
read/write methods are public.
was (Author: zariel):
Fix typo, use tmp names for args/results incase the service defines the
argument name as 'args' or 'result'.
> Pull generated send/recv into library to allow behaviour to be customised
> -------------------------------------------------------------------------
>
> Key: THRIFT-4285
> URL: https://issues.apache.org/jira/browse/THRIFT-4285
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Compiler, Go - Library
> Reporter: Chris Bannister
> Assignee: Chris Bannister
> Attachments: 0001-go-pull-generated-send-recv-into-lib-2.patch,
> 0001-go-pull-generated-send-recv-into-lib.patch,
> 0001-go-pull-generated-send-recv-into-lib-v3.patch,
> 0001-go-pull-generated-send-recv-into-lib-v4.patch
>
>
> Currently it is difficult to change how thrift writes messages onto the
> transport because they are in the generated code. Instead the generated
> send/recv methods should be in the library. This will greatly simplify the
> client code and remove many duplicate methods whilst allowing users more
> flexibility to implement connection pools and other features such as THeader.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
