Github user Typz commented on a diff in the pull request: https://github.com/apache/thrift/pull/1337#discussion_r137811890 --- Diff: lib/cpp/src/thrift/concurrency/TimerManager.cpp --- @@ -290,11 +292,23 @@ void TimerManager::add(shared_ptr<Runnable> task, const struct timeval& value) { } void TimerManager::remove(shared_ptr<Runnable> task) { - (void)task; Synchronized s(monitor_); if (state_ != TimerManager::STARTED) { throw IllegalStateException(); } + std::vector<task_iterator> toRemove; --- End diff -- done
---