[ https://issues.apache.org/jira/browse/THRIFT-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167332#comment-16167332 ]
ASF GitHub Bot commented on THRIFT-4330: ---------------------------------------- GitHub user sadikovi opened a pull request: https://github.com/apache/thrift/pull/1360 THRIFT-4330: Allow unused extern crates This PR adds attribute to the Rust generated code to allow unused crates, since some libraries may not use imports and generate warnings. ``` #![allow(unused_extern_crates)] ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/sadikovi/thrift THRIFT-4330 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1360.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1360 ---- commit 54b12d274616f819a90e16d188f1431260e0ed50 Author: Ivan Sadikov <ivan.sadi...@team.telstra.com> Date: 2017-09-15T05:09:08Z THRIFT-4330: allow unused extern crates ---- > Allow unused crates in Rust files > --------------------------------- > > Key: THRIFT-4330 > URL: https://issues.apache.org/jira/browse/THRIFT-4330 > Project: Thrift > Issue Type: Improvement > Reporter: Ivan Sadikov > Priority: Trivial > Fix For: 0.11.0 > > > Currently thrift generated .rs files include following attributes: > #![allow(unused_imports)] > #![cfg_attr(feature = "cargo-clippy", allow(too_many_arguments, > type_complexity))] > #![cfg_attr(rustfmt, rustfmt_skip)] > I propose to add > #![allow(unused_extern_crates)] > to remove warning when using Rust nightly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)