[
https://issues.apache.org/jira/browse/THRIFT-4331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168275#comment-16168275
]
ASF GitHub Bot commented on THRIFT-4331:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1363#discussion_r139214105
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.cpp ---
@@ -759,7 +775,9 @@ unsigned int TSSLSocket::waitForEvent(bool wantRead) {
struct THRIFT_POLLFD fds[2];
memset(fds, 0, sizeof(fds));
fds[0].fd = fdSocket;
- fds[0].events = wantRead ? THRIFT_POLLIN : THRIFT_POLLOUT;
+ // use POLLIN also on write operations too, this is needed for operations
+ // which requires read and write on the socket.
--- End diff --
Interesting, what's an example of this?
> C++: TSSLSockets bug in handling huge messages, bug in handling polling
> -----------------------------------------------------------------------
>
> Key: THRIFT-4331
> URL: https://issues.apache.org/jira/browse/THRIFT-4331
> Project: Thrift
> Issue Type: Bug
> Components: C++ - Library
> Affects Versions: 0.10.0, 1.0
> Reporter: Martin Haimberger
> Fix For: 0.10.0, 1.0
>
> Attachments: 0.10.0-THRIFT-4331.patch, master-THRIFT-4331.patch
>
>
> The TSSLSocket class did not handle large messages, because a underlying TCP
> socket my signal bytes received, while SSL_read() may not have bytes
> available. After maxretries (5) the function returned -1, which got
> interpreted as unsigned integer for read bytes.
> Futher the waitForEvent methode, did only set THRIFT_POLLIN or
> THRIFT_POLLOUT, but it gets used where SSL needs to send AND receive bytes
> for some operations (like close). So in the case of write wanted,
> THRIFT_POLLIN is also set to cover these read/write operations.
> Pullrequest for master and 0.10.0 branch will follow.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
