[
https://issues.apache.org/jira/browse/THRIFT-4233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16175405#comment-16175405
]
ASF GitHub Bot commented on THRIFT-4233:
----------------------------------------
Github user dmvolod commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1294#discussion_r140350410
--- Diff: lib/java/src/org/apache/thrift/server/THsHaServer.java ---
@@ -154,7 +154,10 @@ protected static ExecutorService
createInvokerPool(Args options) {
return invoker;
}
-
+
+ protected ExecutorService getInvoker() {
--- End diff --
Yes, you are right. I will close this PR, as I'm unable to add commit to
this PR (remove remote repo) and create a new one.
Thank you.
> Make THsHaServer.invoker available (get method only) in inherited classes
> -------------------------------------------------------------------------
>
> Key: THRIFT-4233
> URL: https://issues.apache.org/jira/browse/THRIFT-4233
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Affects Versions: 0.10.0
> Reporter: Dmitry Volodin
> Assignee: James E. King, III
> Priority: Minor
>
> In some cases (for example in Apache Camel component for Thrift) there is a
> requirement, when it is necessary not only to transfer executorService from
> the external system through the Args in THsHaServer , but to organize control
> them from outside. In this case, it's possible to create a class which is
> inherited from THsHaServer, but not possible to access invoker in overloaded
> gracefullyShutdownInvokerPool(). As workaround the TNonblockingServer must be
> extended but requires to create several methods from scratch.
> It's necessary to add code below to THsHaServer
> {code:java}
> protected ExecutorService getInvoker() {
> return invoker;
> }
> {code}
> I'm ready to add this code as PR.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
