Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1391#discussion_r146107107
  
    --- Diff: lib/php/src/ext/thrift_protocol/config.m4 ---
    @@ -1,25 +1,27 @@
    -dnl Copyright (C) 2009 Facebook
    -dnl Copying and distribution of this file, with or without modification,
    -dnl are permitted in any medium without royalty provided the copyright
    -dnl notice and this notice are preserved.
    +dnl Licensed to the Apache Software Foundation (ASF) under one
    --- End diff --
    
    dreiss's copyright statement says, "provided the copyright notice and this 
notice are preserved.".  I don't think we should be removing it.  You can move 
it down to be below the Apache Thrift license, or @jfarrell needs to approve 
this change.



---

Reply via email to