[
https://issues.apache.org/jira/browse/THRIFT-4378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16226199#comment-16226199
]
ASF GitHub Bot commented on THRIFT-4378:
----------------------------------------
Github user itegel commented on the issue:
https://github.com/apache/thrift/pull/1409
I checked the tests, and find nothing to fix. For old version, it is hard
coded the time unit to SECONDS and for default args.stopTimeoutUnit is set to
TimeUnit.SECONDS. So it has not change the default behavior.
> add set stopTimeoutUnit method to TThreadPoolServer
> ---------------------------------------------------
>
> Key: THRIFT-4378
> URL: https://issues.apache.org/jira/browse/THRIFT-4378
> Project: Thrift
> Issue Type: Improvement
> Components: Java - Library
> Environment: java lib
> Reporter: itegel bao
> Priority: Minor
>
> All time units all have set method, except this stopTimeoutUnit, in
> TThreadPoolServer.
> And for default it is se to TimeUnit.SECONDS.
> In our projects we prefer TimeUnit.MILLISECONDS to TimeUnit.SECONDS, at least
> we want it to be the same over whole project.
> So can we add a set methods for stopTimeoutUnit
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
