[
https://issues.apache.org/jira/browse/THRIFT-4329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248540#comment-16248540
]
ASF GitHub Bot commented on THRIFT-4329:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1361
If I merge this, it will break all future builds.
Errors in c_glib start at:
https://travis-ci.org/apache/thrift/jobs/300505547 line 2990
if you run the docket ubuntu-xenial image and build inside it, you will see
them
https://travis-ci.org/apache/thrift/jobs/300505547 line 2985
if you run the docket ubuntu-trusty image and build inside it, you will see
them
they look quite similar to the ubuntu-xenial image issues
Suggest you build inside a docker image to verify your fixes. Here is how
I do it:
This is my `~/.bash_aliases` file:
```
# Kill all running containers.
alias dockerkillall='docker kill $(docker ps -q)'
# Delete all stopped containers.
alias dockercleanc='printf "\n>>> Deleting stopped containers\n\n" &&
docker rm $(docker ps -a -q)'
# Delete all untagged images.
alias dockercleani='printf "\n>>> Deleting untagged images\n\n" && docker
rmi $(docker images -q -f dangling=true)'
# Delete all stopped containers and untagged images.
alias dockerclean='dockercleanc || true && dockercleani'
# Build a thrift docker image (run from top level of git repo): argument #1
is image type (ubuntu, centos, etc).
function dockerbuild
{
docker build -t $1 build/docker/$1
}
# Run a thrift docker image: argument #1 is image type (ubuntu, centos,
etc).
function dockerrun
{
docker run -v $(pwd):/thrift/src -it $1 /bin/bash
}
```
To pull down the current image being used to build (the same way Travis CI
does it) - if it is out of date in any way it will build a new one for you.
```
thrift$ DOCKER_REPO=thrift/thrift-build DISTRO=ubuntu-xenial
build/docker/refresh.sh
```
To run all unit tests (just like Travis CI):
```
thrift$ dockerrun ubuntu-xenial
root@8caf56b0ce7b:/thrift/src# build/docker/scripts/autotools.sh
```
To run the cross tests (just like Travis CI):
```
thrift$ dockerrun ubuntu-xenial
root@8caf56b0ce7b:/thrift/src# build/docker/scripts/cross-test.sh
```
When you are done, you want to clean up occasionally so that docker isn't
using lots of extra disk space:
```
thrift$ dockerclean
```
You need to run the docker commands from the root of the git repository for
them to work.
When you are done in the root docker shell you can `exit` to go back to
your user host shell. Once the unit tests and cross test passes locally, then
submit he changes, and squash the pull request to one commit to make it easier
to merge. Thanks. I am going to update the docker README.md with this
information so others can leverage it too. Now you are building like Travis CI
does!
> c_glib Doesn't have a multiplexed processor
> -------------------------------------------
>
> Key: THRIFT-4329
> URL: https://issues.apache.org/jira/browse/THRIFT-4329
> Project: Thrift
> Issue Type: Bug
> Components: C glib - Library
> Affects Versions: 0.10.0
> Reporter: Gonzalo Aguilar
> Assignee: Gonzalo Aguilar
>
> It seems that multiplexed protocol only implements
> thrift_multiplexed_protocol_write_message_begin that's ok for sending
> messages to a multiplexed server but not for the C server. We also need a
> multiplexed processor for the server.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
