[
https://issues.apache.org/jira/browse/THRIFT-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271246#comment-16271246
]
ASF GitHub Bot commented on THRIFT-4395:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1420
THRIFT-4395: fix rust build on xenial
I found this while doing due diligence on another issue (C++ HTTP) - I
could no longer run cross test because builds fail in lib/rs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift fix-rust
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1420
----
commit 7d83cb4a2cafe033e7d18705cc0f74cd9b883cd5
Author: Chet Murthy <chet...@gmail.com>
Date: 2017-11-27T00:39:15Z
THRIFT-3877 unit-test elicits failure of C++/HTTP/oneway hang
Hit a C++ HTTP server with a oneway rpc, and the next RPC will hang.
This test-case elicits the failure (converts to timeout-expiry).
commit 10c8951de5f483b9bc71e2aa1558dd0170389bce
Author: Chet Murthy <chet...@gmail.com>
Date: 2017-11-27T00:42:28Z
THRIFT-3877 this fixes the subject bug
C++ HTTP server, hit with oneway RPC, then roundtrip RPC, no longer
hangs, as demonstrated by OneWayHTTPTest.
commit 6ec809a2b50822908971b420f1deea01ead72566
Author: Chet Murthy <chet...@gmail.com>
Date: 2017-11-27T03:29:27Z
agh. left off a makefile dependency
commit 217fa08d9c9eee9f057bdafc867ad11a8d91b798
Author: James E. King, III <jk...@apache.org>
Date: 2017-11-29T18:01:16Z
THRIFT-4395: fix rust build on xenial
----
> Unable to build in the ubuntu-xenial docker image: clap 2.28 requires Rust
> 1.20
> -------------------------------------------------------------------------------
>
> Key: THRIFT-4395
> URL: https://issues.apache.org/jira/browse/THRIFT-4395
> Project: Thrift
> Issue Type: Bug
> Components: Rust - Library
> Affects Versions: 0.10.0
> Environment: docker image ubuntu-xenial
> Reporter: James E. King, III
> Assignee: James E. King, III
> Priority: Blocker
> Fix For: 0.11.0
>
>
> bitflags-1.0.0 and later is incompatible with Rust 1.19 and earlier
> clap has to be limited to under 2.28 in order for builds to keep working.
> {noformat}
> /usr/bin/cargo build
> Updating registry `https://github.com/rust-lang/crates.io-index`
> Compiling bitflags v1.0.1
> Compiling integer-encoding v1.0.4
> Compiling num-traits v0.1.40
> Compiling byteorder v1.1.0
> error: expected ident, found #
> -->
> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/bitflags-1.0.1/src/lib.rs:423:29
> |
> 423 | #[allow(deprecated)]
> | ^
> |
> :::
> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/bitflags-1.0.1/src/example_generated.rs
> |
> 4 | bitflags! {
> | - in this macro invocation
> error: Could not compile `bitflags`.
> Build failed, waiting for other jobs to finish...
> error: build failed
> Makefile:634: recipe for target 'check' failed
> make[1]: *** [check] Error 101
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
