[ https://issues.apache.org/jira/browse/THRIFT-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272096#comment-16272096 ]
ASF GitHub Bot commented on THRIFT-3657: ---------------------------------------- GitHub user jeking3 opened a pull request: https://github.com/apache/thrift/pull/1427 THRIFT-3657 D TFileWriterTransport close should use non-priority send Client: D (resubmit for nsuke) This closes #884 This closes #1427 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jeking3/thrift THRIFT-3657-take-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1427.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1427 ---- commit 87b8992ba21efd2328435015d301ef69a02c1f74 Author: Nobuaki Sukegawa <ns...@apache.org> Date: 2016-02-21T17:16:30Z THRIFT-3657 D TFileWriterTransport close should use non-priority send Client: D This closes #884 This closes #1427 ---- > D TFileWriterTransport close should use non-priority send > --------------------------------------------------------- > > Key: THRIFT-3657 > URL: https://issues.apache.org/jira/browse/THRIFT-3657 > Project: Thrift > Issue Type: Bug > Components: D - Library > Reporter: Aki Sukegawa > Assignee: Aki Sukegawa > Priority: Trivial > > prioritySend is used in TFileWriterTransport close method. > A possible problem with this is that even synchronized calls that are > strictly before close call can be ignored in rare occasions. > The author has put a comment "FIXME: Should use normal send here" and there's > no reason not to. > I suspect it is a remnant of old implementation or local debug stuff. -- This message was sent by Atlassian JIRA (v6.4.14#64029)