[ https://issues.apache.org/jira/browse/THRIFT-4403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276713#comment-16276713 ]
ASF GitHub Bot commented on THRIFT-4403: ---------------------------------------- GitHub user bananer opened a pull request: https://github.com/apache/thrift/pull/1437 THRIFT-4403: Fix incorrect usage of 'this' You can merge this pull request into a Git repository by running: $ git pull https://github.com/bananer/thrift THRIFT-4403 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1437.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1437 ---- commit b55a32939a250a4c04d64d6b1821fc766944d444 Author: Philip Frank <i...@philipfrank.de> Date: 2017-12-04T12:29:58Z Fix incorrect usage of 'this' ---- > thrift.js: Incorrect usage of 'this' in TWebSocketTransport.__onOpen > -------------------------------------------------------------------- > > Key: THRIFT-4403 > URL: https://issues.apache.org/jira/browse/THRIFT-4403 > Project: Thrift > Issue Type: Bug > Reporter: Philip Frank > > Inside the forEach callback 'this' will be the global object, not the > transport object, as the implementation seems to assume. -- This message was sent by Atlassian JIRA (v6.4.14#64029)