[
https://issues.apache.org/jira/browse/THRIFT-4416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16284833#comment-16284833
]
ASF GitHub Bot commented on THRIFT-4416:
----------------------------------------
GitHub user jeking3 opened a pull request:
https://github.com/apache/thrift/pull/1441
THRIFT-4416: Automate and fix CPAN packaging
* Ensures only necessary files are in the manifest.
* Ensures that META.json has the syntactic sugar to properly index Thrift
as a single package.
* Shell script is now designed to be run inside one of the docker images,
grabbing some things from CPAN to ensure a solid delivery.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeking3/thrift THRIFT-4416
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1441.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1441
----
commit 985ee2eb0509b219e4f0df8605ce8af6abeaf71c
Author: James E. King, III <jk...@apache.org>
Date: 2017-12-09T15:10:03Z
THRIFT-4416: fixed up CPAN module creation and automated all steps except
for upload to CPAN
Client: perl
This closes #1441
----
> Perl CPAN Packaging Improvements
> --------------------------------
>
> Key: THRIFT-4416
> URL: https://issues.apache.org/jira/browse/THRIFT-4416
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process, Perl - Library
> Affects Versions: 0.10.0, 0.11.0
> Environment: CPAN
> Reporter: James E. King, III
> Assignee: James E. King, III
>
> The perl library has a few files and a shell script designed to automate the
> production of a perl package for CPAN. It mostly works, however:
> 1. CPAN cannot parse the package version references we use when we point to
> lib/Thrift.pm from other packages. This is fixed by adding a provides{}
> stanza to META.json.
> 2. Users of CPAN don't care about anything but obtaining the "Thrift" package
> that contains all the others, so identifying the others (like
> Thrift::BinaryProtocol) is not necessary. This is done by adding a
> provides{} stanza to META.json.
> 3. The CPAN package no longer needs the META.yml file, as META.json is
> sufficient.
> 4. These changes were made by hand to the 0.11.0 package before uploading to
> CPAN. This needs to be automated.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
