Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1464#discussion_r161212364
--- Diff: build/docker/ubuntu-artful/Dockerfile ---
@@ -41,10 +43,21 @@ RUN apt-get update && \
# dotnet (core)
RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor
> /etc/apt/trusted.gpg.d/microsoft.gpg && \
- echo "deb [arch=amd64]
https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main"
> /etc/apt/sources.list.d/dotnetdev.list
+ echo "deb [arch=amd64]
https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main"
> \
+ /etc/apt/sources.list.d/dotnetdev.list
-# node.js (this step runs apt-get update internally) - if we ever want a
later version
-RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
+# node.js
+RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo
apt-key add - \
--- End diff --
sudo is unnecessary and causes a failure in a docker container (see build)
---
