[
https://issues.apache.org/jira/browse/THRIFT-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323895#comment-16323895
]
ASF GitHub Bot commented on THRIFT-4452:
----------------------------------------
Github user jeking3 commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1464#discussion_r161212364
--- Diff: build/docker/ubuntu-artful/Dockerfile ---
@@ -41,10 +43,21 @@ RUN apt-get update && \
# dotnet (core)
RUN curl https://packages.microsoft.com/keys/microsoft.asc | gpg --dearmor
> /etc/apt/trusted.gpg.d/microsoft.gpg && \
- echo "deb [arch=amd64]
https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main"
> /etc/apt/sources.list.d/dotnetdev.list
+ echo "deb [arch=amd64]
https://packages.microsoft.com/repos/microsoft-ubuntu-artful-prod artful main"
> \
+ /etc/apt/sources.list.d/dotnetdev.list
-# node.js (this step runs apt-get update internally) - if we ever want a
later version
-RUN curl -sL https://deb.nodesource.com/setup_8.x | bash -
+# node.js
+RUN curl -sL https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo
apt-key add - \
--- End diff --
sudo is unnecessary and causes a failure in a docker container (see build)
> optimize Dockerfile (only onetime apt-get update)
> -------------------------------------------------
>
> Key: THRIFT-4452
> URL: https://issues.apache.org/jira/browse/THRIFT-4452
> Project: Thrift
> Issue Type: Improvement
> Components: Build Process
> Affects Versions: 0.11.0
> Reporter: Robert Lu
> Assignee: Robert Lu
> Priority: Minor
>
> When build
> [apache/thrift-build|https://github.com/apache/thrift/blob/a15060a/build/docker/ubuntu-trusty/Dockerfile],
> there are many times to run apt-get update.
> We can just run one time apt-get update after add all repo.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
