[ https://issues.apache.org/jira/browse/THRIFT-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325190#comment-16325190 ]
ASF GitHub Bot commented on THRIFT-4434: ---------------------------------------- Github user vgotra commented on a diff in the pull request: https://github.com/apache/thrift/pull/1449#discussion_r161375224 --- Diff: lib/netcore/Makefile.am --- @@ -19,86 +19,25 @@ SUBDIRS = . -THRIFT = $(top_builddir)/compiler/cpp/thrift - -TESTDIR = Tests/Thrift.PublicInterfaces.Compile.Tests -GENDIR = $(TESTDIR)/gen-netcore - THRIFTCODE = \ - Thrift/Thrift.csproj \ - Thrift/ITAsyncProcessor.cs \ - Thrift/ITProcessorFactory.cs \ - Thrift/SingletonTProcessorFactory.cs \ - Thrift/TApplicationException.cs \ - Thrift/TBaseClient.cs \ - Thrift/TException.cs \ - Thrift/TMultiplexedProcessor.cs \ - Thrift/Collections/TCollections.cs \ - Thrift/Collections/THashSet.cs \ - Thrift/Properties/AssemblyInfo.cs \ - Thrift/Protocols/ITProtocolFactory.cs \ - Thrift/Protocols/TAbstractBase.cs \ - Thrift/Protocols/TBase.cs \ - Thrift/Protocols/TBinaryProtocol.cs \ - Thrift/Protocols/TCompactProtocol.cs \ - Thrift/Protocols/TJSONProtocol.cs \ - Thrift/Protocols/TMultiplexedProtocol.cs \ - Thrift/Protocols/TProtocol.cs \ - Thrift/Protocols/TProtocolDecorator.cs \ - Thrift/Protocols/TProtocolException.cs \ - Thrift/Protocols/Entities/TField.cs \ - Thrift/Protocols/Entities/TList.cs \ - Thrift/Protocols/Entities/TMap.cs \ - Thrift/Protocols/Entities/TMessage.cs \ - Thrift/Protocols/Entities/TMessageType.cs \ - Thrift/Protocols/Entities/TSet.cs \ - Thrift/Protocols/Entities/TStruct.cs \ - Thrift/Protocols/Entities/TType.cs \ - Thrift/Protocols/Utilities/TBase64Utils.cs \ - Thrift/Protocols/Utilities/TProtocolUtil.cs \ - Thrift/Server/AsyncBaseServer.cs \ - Thrift/Server/TBaseServer.cs \ - Thrift/Server/TServerEventHandler.cs \ - Thrift/Transports/TClientTransport.cs \ - Thrift/Transports/TServerTransport.cs \ - Thrift/Transports/TTransportException.cs \ - Thrift/Transports/TTransportFactory.cs \ - Thrift/Transports/Client/TBufferedClientTransport.cs \ - Thrift/Transports/Client/TFramedClientTransport.cs \ - Thrift/Transports/Client/THttpClientTransport.cs \ - Thrift/Transports/Client/TMemoryBufferClientTransport.cs \ - Thrift/Transports/Client/TNamedPipeClientTransport.cs \ - Thrift/Transports/Client/TSocketClientTransport.cs \ - Thrift/Transports/Client/TStreamClientTransport.cs \ - Thrift/Transports/Client/TTlsSocketClientTransport.cs \ - Thrift/Transports/Server/THttpServerTransport.cs \ - Thrift/Transports/Server/TNamedPipeServerTransport.cs \ - Thrift/Transports/Server/TServerFramedTransport.cs \ - Thrift/Transports/Server/TServerSocketTransport.cs \ - Thrift/Transports/Server/TTlsServerSocketTransport.cs + Thrift/Thrift.csproj all-local: \ --- End diff -- Sure > Update .NET Core components, add tests for .Net Core library and .Net Core > compiler, fix bugs and build process > --------------------------------------------------------------------------------------------------------------- > > Key: THRIFT-4434 > URL: https://issues.apache.org/jira/browse/THRIFT-4434 > Project: Thrift > Issue Type: Improvement > Components: .NETCore - Compiler, .NETCore - Library, Build Process > Environment: Windows, Linux, MacOS > Reporter: Volodymyr Gotra > Assignee: Volodymyr Gotra > Priority: Critical > > This pull request should: > - highly improve the current version of .Net Core library and .Net Core > compiler and quality of code > - improve and simplify build process > - improve documentation related to .Net Core library and compiler > - fix found bugs (some of bugs can be clarified like major - they are related > to porting of protocols from Java version and can be present in C# library) > - add important unit tests for .Net Core library and .Net Core compiler > - add possibility to easy add unit tests for compiler for other languages -- This message was sent by Atlassian JIRA (v6.4.14#64029)