[ https://issues.apache.org/jira/browse/THRIFT-4473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16338018#comment-16338018 ]
ASF GitHub Bot commented on THRIFT-4473: ---------------------------------------- GitHub user Jens-G opened a pull request: https://github.com/apache/thrift/pull/1478 THRIFT-4473 Move Thrift.Console.pas out of the Library Client: Delphi Patch: Jens Geyer You can merge this pull request into a Git repository by running: $ git pull https://github.com/Jens-G/thrift THRIFT-4473 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1478.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1478 ---- commit cf753348438bf800446e393a6d114408b314f438 Author: Jens Geyer <jensg@...> Date: 2018-01-24T18:14:32Z THRIFT-4473 Move Thrift.Console.pas out of the Library Client: Delphi Patch: Jens Geyer ---- > Move Thrift.Console.pas out of the Library > ------------------------------------------ > > Key: THRIFT-4473 > URL: https://issues.apache.org/jira/browse/THRIFT-4473 > Project: Thrift > Issue Type: Improvement > Components: Delphi - Library > Reporter: Jens Geyer > Assignee: Jens Geyer > Priority: Major > > Thrift.Console.pas is ok as part of the tests, but should not be in the > library. The code does neither belong into the library nor does it adhere to > quality standards expected for a software library. It's ok for the tests > suite though. -- This message was sent by Atlassian JIRA (v7.6.3#76005)