Github user bgedik commented on a diff in the pull request:
https://github.com/apache/thrift/pull/1476#discussion_r163651048
--- Diff: lib/cpp/src/thrift/transport/TSSLSocket.h ---
@@ -78,6 +78,7 @@ class TSSLSocket : public TSocket {
bool peek();
void open();
void close();
+ bool hasPendingDataToRead();
--- End diff --
I implemented option #2. In terms of your matrix choice suggestion: How can
we make that happen? Is that something I can help with? I am bothered by the
TNonblockingSeverTest not catching the problem reported in this bug. The moment
we switched to 0.11, it started throwing unexpected exceptions for us, when
using Java client against C++ server. This should have been caught by the
existing tests, but it did not happen. I would like to help with this. So if
you have a suggestion for me, please let me know.
---
