[ https://issues.apache.org/jira/browse/THRIFT-4475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16340450#comment-16340450 ]
ASF GitHub Bot commented on THRIFT-4475: ---------------------------------------- GitHub user RobberPhex opened a pull request: https://github.com/apache/thrift/pull/1482 THRIFT-4475: check lib/php/test for PSR-2 ref: https://issues.apache.org/jira/browse/THRIFT-4475 You can merge this pull request into a Git repository by running: $ git pull https://github.com/RobberPhex/thrift psr-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/thrift/pull/1482.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1482 ---- commit 8ffd8855c15ab8e04e1ad786d6062f837acdff2b Author: Robert Lu <robberphex@...> Date: 2018-01-25T15:19:41Z check lib/php/test ---- > lib/php/test should be checked for PSR-2 > ---------------------------------------- > > Key: THRIFT-4475 > URL: https://issues.apache.org/jira/browse/THRIFT-4475 > Project: Thrift > Issue Type: Improvement > Components: PHP - Library > Affects Versions: 0.11.0 > Reporter: Robert Lu > Assignee: Robert Lu > Priority: Minor > > The test code at {{lib/php/test}} should also be checked by phpcs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)