[
https://issues.apache.org/jira/browse/THRIFT-4454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16349443#comment-16349443
]
ASF GitHub Bot commented on THRIFT-4454:
----------------------------------------
GitHub user Jens-G opened a pull request:
https://github.com/apache/thrift/pull/1490
THRIFT-4454 Large writes/reads may cause range check errors in debug …
…mode
Client: Delphi
Patch: Jens Geyer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Jens-G/thrift THRIFT-4454
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1490.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1490
----
commit df265ad7de0ee7f8faf89e32a3f05bbc75f5343b
Author: Jens Geyer <jensg@...>
Date: 2018-02-01T21:37:18Z
THRIFT-4454 Large writes/reads may cause range check errors in debug mode
Client: Delphi
Patch: Jens Geyer
----
> Large writes/reads may cause range check errors in debug mode
> -------------------------------------------------------------
>
> Key: THRIFT-4454
> URL: https://issues.apache.org/jira/browse/THRIFT-4454
> Project: Thrift
> Issue Type: Bug
> Components: Delphi - Library
> Affects Versions: 0.11.0
> Reporter: Jens Geyer
> Assignee: Jens Geyer
> Priority: Major
> Fix For: 0.12.0
>
>
> The pipes code contains a few casts using the {{PByteArray}} pointer type.
> The underlying array {{TByteArray}} is defined as {code}
> type TByteArray = array [0..32767] of Byte;
> {code}
> With range checks enabled, any access to indices > 32767, even correct ones,
> result in an range check exception. It may be worth noting that the code is
> otherwise entirely correct (i.e. no buffer overruns). It is really only the
> type cast that introduces the failing constraint.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
