GitHub user bgedik reopened a pull request:
https://github.com/apache/thrift/pull/1476
Remove premature call to workSocket() in TNonblockingServer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgedik/thrift
bugfix/non-blocking-server-calls-workSocket-too-early
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1476.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1476
----
commit f3c682e9c41d67d8cd1ab2d75f6259b6e0af40da
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-21T17:43:49Z
remove workSocket call that is too early
commit e115634a2a9844d08a6d017859e3d838414d2194
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T00:35:31Z
Make the work socket conditional
commit 8e5ba48c9d62ee4ae79aac5f2cc4f98d2f535866
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T01:03:04Z
Revert back the changes
commit 017d242479c985a9cb476bcd2da22abaa62ed052
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T18:52:33Z
Only call workSocket() when there is pending data to read
commit c929047d4a43c3969cc40b204e3717877667edb2
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T19:29:12Z
Minor update to a comment
commit fb72b94b513f665e49488d8aaee7eda3f4b57a94
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T20:51:55Z
Only call workSocket() when there is pending data to read
commit 4777cab48641d23bd2246248a07a7a4249a3709f
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T21:43:04Z
Only call workSocket() when there is pending data to read
commit f69e91be02275c8a06f489030fcda24449329ce2
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T23:44:10Z
Fix the CMake build
commit 84051190db3234468ffed11a2a61ab8ba6d7e1fd
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T23:49:27Z
Fix the CMake build
commit 7b60db3a5535195ec6096fea8ead757266d716b5
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-22T23:58:34Z
Fix the CMake build
commit 081096091cc828dd7dbcf0962cdaa6c791317e0c
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-23T00:14:09Z
Use the correct type for ioctlsocket call
commit 501c4401ddb93cf9bf451dd289d4c3768c0a7b15
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-24T19:19:57Z
Make non-blocking peek optional
commit a9dc3f118acb820189696bd13735444ad2d129a3
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-24T20:46:40Z
Revert "Make non-blocking peek optional"
This reverts commit 501c4401ddb93cf9bf451dd289d4c3768c0a7b15.
commit c8d422a633a6b848982c48cb769285906f2ea027
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-24T21:12:35Z
Review fixes
commit d64a8e0d4709ece4086f054fae7c1c98e3a0ca77
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-24T21:15:14Z
Review fixes
commit 83d3c13f09238831e2d06e8b67a018acbcc656c4
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-24T21:16:28Z
Review fixes
----
---
