GitHub user bgedik opened a pull request:
https://github.com/apache/thrift/pull/1497
Remove workSocket call that is too early
Make the work socket conditional
Revert back the changes
Only call workSocket() when there is pending data to read
Minor update to a comment
Only call workSocket() when there is pending data to read
Only call workSocket() when there is pending data to read
Fix the CMake build
Fix the CMake build
Fix the CMake build
Use the correct type for ioctlsocket call
Make non-blocking peek optional
Revert "Make non-blocking peek optional"
This reverts commit 501c4401ddb93cf9bf451dd289d4c3768c0a7b15.
Review fixes
Review fixes
Review fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bgedik/thrift
bugfix/non-blocking-server-calls-workSocket-too-early
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1497.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1497
----
commit 6665029561d40d5b89b7ee9cb2487f6c905b904a
Author: Bugra Gedik <bgedik@...>
Date: 2018-01-21T17:43:49Z
remove workSocket call that is too early
Make the work socket conditional
Revert back the changes
Only call workSocket() when there is pending data to read
Minor update to a comment
Only call workSocket() when there is pending data to read
Only call workSocket() when there is pending data to read
Fix the CMake build
Fix the CMake build
Fix the CMake build
Use the correct type for ioctlsocket call
Make non-blocking peek optional
Revert "Make non-blocking peek optional"
This reverts commit 501c4401ddb93cf9bf451dd289d4c3768c0a7b15.
Review fixes
Review fixes
Review fixes
----
---
