GitHub user bananer opened a pull request:

    https://github.com/apache/thrift/pull/1501

    THRIFT-4509: remove nodejs browser test

    Removes the dependency on outdated npm libraries.
    
    This test was previously disabled, and I think it is safe to remove since 
the communication between browser client and nodejs server is already being 
tested properly from the JS perspective.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bananer/thrift 
THRIFT-4509-remove-nodejs-browser-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/1501.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1501
    
----
commit e1bfa1e42458c8ececd386d532b7f573da717fcc
Author: Philip Frank <ich@...>
Date:   2018-03-07T17:01:56Z

    THRIFT-4509: remove nodejs browser test

----


---

Reply via email to