Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/1497
  
    You need to create a Jira ticket in the THRIFT project 
(https://issues.apache.org/jira/projects/THRIFT/issues) that describes the bug 
and resolution so that I can merge it.
    
    ---
    
    I was able to test these changes out by making some changes to the cpp 
TestServer for crosstest which I will check in today.  I changed my local 
tests.json file to add "--server-type=nonblocking" to each cpp server and 
changed some code to make additional cases work:
    
    ```
    root@8d560c4cc0fa:/thrift/src# test/test.py --server cpp --client cpp 
--regex='.*framed.*-ip.*'
    Apache Thrift - Integration Test Suite
    Sun Mar 11 14:49:02 2018
    
===============================================================================
    server-client:          protocol:         transport:               result:
    cpp-cpp                 compact           framed-ip                success
    cpp-cpp                 multi-binary      framed-ip                success
    cpp-cpp                 compact           framed-ip-ssl            success
    cpp-cpp                 multih            framed-ip-ssl            success
    cpp-cpp                 multih            framed-ip                success
    cpp-cpp                 multi-binary      framed-ip-ssl            success
    cpp-cpp                 multih-header     framed-ip                success
    cpp-cpp                 multih-header     framed-ip-ssl            success
    cpp-cpp                 multij-json       framed-ip-ssl            success
    cpp-cpp                 multij-json       framed-ip                success
    cpp-cpp                 json              framed-ip                success
    cpp-cpp                 json              framed-ip-ssl            success
    cpp-cpp                 multic            framed-ip                success
    cpp-cpp                 multic            framed-ip-ssl            success
    cpp-cpp                 multic-compact    framed-ip                success
    cpp-cpp                 multic-compact    framed-ip-ssl            success
    cpp-cpp                 multij-json       framed-ip-ssl            success
    cpp-cpp                 multij-json       framed-ip                success
    cpp-cpp                 header            framed-ip                
failure(-6)
    cpp-cpp                 multij            framed-ip                success
    cpp-cpp                 multij            framed-ip-ssl            success
    cpp-cpp                 header            framed-ip-ssl            
failure(-6)
    cpp-cpp                 multic-compact    framed-ip                success
    cpp-cpp                 multic-compact    framed-ip-ssl            success
    cpp-cpp                 multi-binary      framed-ip-ssl            success
    cpp-cpp                 multi-binary      framed-ip                success
    cpp-cpp                 multi             framed-ip-ssl            success
    cpp-cpp                 multi             framed-ip                success
    cpp-cpp                 multih-header     framed-ip-ssl            success
    cpp-cpp                 multih-header     framed-ip                success
    cpp-cpp                 binary            framed-ip-ssl            success
    cpp-cpp                 binary            framed-ip                success
    
===============================================================================
    ```
    (I think you can ignore the header failures)


---

Reply via email to