[
https://issues.apache.org/jira/browse/THRIFT-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400517#comment-16400517
]
ASF GitHub Bot commented on THRIFT-4516:
----------------------------------------
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1507
I'll keep an eye on this. Right now the docker images on docker.io have to
be generated manually every time they are updated, otherwise the build jobs
take more time than they should.
> Add support for go 1.10
> -----------------------
>
> Key: THRIFT-4516
> URL: https://issues.apache.org/jira/browse/THRIFT-4516
> Project: Thrift
> Issue Type: Improvement
> Components: Go - Library
> Affects Versions: 0.11.0
> Environment: ubuntu-artful (using go 1.10 instead of 1.9)
> Reporter: James E. King, III
> Assignee: Can Celasun
> Priority: Major
>
> Currently go 1.10 has additional type checking on format strings that prevent
> thrift from compiling and running tests. We are limited to go 1.9 until this
> is resolved.
> Example:
> {noformat}
> thrift/protocol_test.go:442: Errorf format %s has arg thelen of wrong type int
> thrift/protocol_test.go:447: Errorf format %q has arg v of wrong type float64
> thrift/protocol_test.go:451: Errorf format %q has arg v of wrong type float64
> thrift/protocol_test.go:454: Errorf format %q has arg value of wrong type
> float64
> thrift/protocol_test.go:482: Errorf format %s has arg thelen of wrong type int
> thrift/protocol_test.go:491: Errorf format %d has arg v of wrong type string
> gopath/src/dontexportrwtest/compile_test.go:32: Sprintf format %v arg s.read
> is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:33: Sprintf format %v arg s.write
> is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:36: Sprintf format %v arg is.read
> is a func value, not called
> gopath/src/dontexportrwtest/compile_test.go:37: Sprintf format %v arg
> is.write is a func value, not called{noformat}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
