Github user jeking3 commented on a diff in the pull request:

    https://github.com/apache/thrift/pull/1496#discussion_r175276394
  
    --- Diff: build/appveyor/MSVC-appveyor-build.bat ---
    @@ -39,7 +39,7 @@ CD "%BUILDDIR%"                             || EXIT /B
         -DWITH_PYTHON=%WITH_PYTHON% ^
         -DWITH_%THREADMODEL%THREADS=ON ^
         -DWITH_SHARED_LIB=OFF ^
    -    -DWITH_STATIC_LIB=ON                    || EXIT /B
    +    -DWITH_STATIC_LIB=ON ^                    || EXIT /B
    --- End diff --
    
    The carat addition looks wrong to me; it belongs on the end of a string, so 
in this case I think it does nothing at all?


---

Reply via email to