[ https://issues.apache.org/jira/browse/THRIFT-4535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421301#comment-16421301 ]
Christian Weiss commented on THRIFT-4535: ----------------------------------------- No worries. I'm not judging anyone and I apologize as well, if I made anyone feel that way. Communication in written-only form in a foreign language is not always easy. I only tried to analyze and understand the current code base. I've also not demanded anything from you or complained about anything - I have instead offered to create a PR. {quote}Even after having looked at the code, I do not really understand that if you've never intended to deprecate one. {quote} Maybe I should clarify this statement. I wrote this because both code bases use the same PackageId so it currently isn't possible to release both versions separately on nuget.org. This was a clear indication for me, as being new to this project, that one of them has to be "newer" and is meant to replace the other. Anyway, back to what can/should be done. Both of you have said that it makes sense to have just one code base so it seems like we're all on the same side. :) The currently open PR is just code cleanup - there's projects that like this kind of PRs and there's projects that don't. Feel free to close it, if you think it's better to not fix tabs/spaces etc in existing files. I was doing that because I had to go through the code base anyway to understand it. My next PR would be an attempt to create a project file with the new format that supports multiple platforms with as few changes as possible. > Current state and future of .NET libraries ("csharp" and "netcore")? > -------------------------------------------------------------------- > > Key: THRIFT-4535 > URL: https://issues.apache.org/jira/browse/THRIFT-4535 > Project: Thrift > Issue Type: Question > Components: C# - Library, netcore - Library > Reporter: Christian Weiss > Priority: Major > > Hi, > We are trying to use Thrift in one of our projects but we ran into some very > fundamental issues: > * The "csharp" project does not target ".NET Standard" and there's only a > very old release on nuget.org ( if [https://www.nuget.org/packages/Thrift/] > is the official one). > * The "netcore" project does target ".NET Standard" but there's no release > yet ( https://issues.apache.org/jira/browse/THRIFT-4512 ) and it also has a > dependency on ASP.NET Core ( > https://issues.apache.org/jira/browse/THRIFT-4534 ) which makes it unusable > in non-web projects. > I'm wondering why there even are 2 separate projects for .NET? It's important > to understand that ".NET Core" is not a new programming API - It's just a new > platform - very similar to Silverlight, Mono, Windows Phone. This means that > it would also be possible to support .NET Core and the new ".NET Standard" > (which represents a common set of APIs for all platforms) with the existing > "csharp" project. > Was this a deliberate decision - e.g. to make the "netcore" code the official > successor of the "csharp" code? > Would you be interested in merging the code back into one library? I'd be > willing to help if you want! > It would be great to get one proper, up to date and official .NET library > soon as there's already quite a lot of weird forks on NuGet.org: > https://www.nuget.org/packages?q=Thrift -- This message was sent by Atlassian JIRA (v7.6.3#76005)