[ 
https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433893#comment-16433893
 ] 

Mustafa Şenol Coşar commented on THRIFT-4532:
---------------------------------------------

[~jking3] I implemented the feature and wrote a test, But I can't make the test 
work on either appveyor or travis-ci.

I need to invoke the compiler from a Python script but the test cannot find the 
executable there, even though its there after I run "make" on my local.

You can look at the diff here: 
[https://github.com/apache/thrift/compare/master...mustafa-cosar:THRIFT-4532]

Test-related changes are in
 * 
https://github.com/apache/thrift/compare/master...mustafa-cosar:THRIFT-4532#diff-69bfe4b7a34a3480a6f449d4186b0ddc
 * 
https://github.com/apache/thrift/compare/master...mustafa-cosar:THRIFT-4532#diff-bec97bbaec40a37941cac3481d5fe596

 

> Avoid updating Thrift compiler generated code if the output has not changed
> ---------------------------------------------------------------------------
>
>                 Key: THRIFT-4532
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4532
>             Project: Thrift
>          Issue Type: Improvement
>          Components: Compiler (General)
>    Affects Versions: 0.11.0
>            Reporter: Buğra Gedik
>            Priority: Minor
>             Fix For: 0.12.0
>
>
> We would like to contribute an improvement to the Thrift compiler that would 
> avoid regenerating target file(s) if they are going to be exactly the same as 
> the ones already present in the same place. This will help when running the 
> Thrift compiler in our build, especially in recursive mode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to