[
https://issues.apache.org/jira/browse/THRIFT-4548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441810#comment-16441810
]
ASF GitHub Bot commented on THRIFT-4548:
----------------------------------------
jeking3 commented on a change in pull request #1547: THRIFT-4548: python binary
accelerated protocol with multiplexing via decoration
URL: https://github.com/apache/thrift/pull/1547#discussion_r182295856
##########
File path: lib/py/src/protocol/TMultiplexedProtocol.py
##########
@@ -25,16 +25,15 @@
class TMultiplexedProtocol(TProtocolDecorator.TProtocolDecorator):
def __init__(self, protocol, serviceName):
- TProtocolDecorator.TProtocolDecorator.__init__(self, protocol)
self.serviceName = serviceName
def writeMessageBegin(self, name, type, seqid):
if (type == TMessageType.CALL or
type == TMessageType.ONEWAY):
- self.protocol.writeMessageBegin(
+ super().writeMessageBegin(
self.serviceName + SEPARATOR + name,
type,
seqid
)
else:
- self.protocol.writeMessageBegin(name, type, seqid)
+ super().writeMessageBegin(name, type, seqid)
Review comment:
super() takes at least 1 argument
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Supporting TBinaryProtocolAccelerated protocol when using
> TMultiplexedProcessor in Python
> -----------------------------------------------------------------------------------------
>
> Key: THRIFT-4548
> URL: https://issues.apache.org/jira/browse/THRIFT-4548
> Project: Thrift
> Issue Type: Bug
> Reporter: Balazs Kemenes
> Priority: Major
>
> Supporting TBinaryProtocolAccelerated protocol when using
> TMultiplexedProcessor in Python
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
