[
https://issues.apache.org/jira/browse/THRIFT-4532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441907#comment-16441907
]
ASF GitHub Bot commented on THRIFT-4532:
----------------------------------------
bgedik commented on issue #1541: THRIFT-4532: Do not update previously
generated output files if the contents have not changed
URL: https://github.com/apache/thrift/pull/1541#issuecomment-382262520
I was thinking that this won't break existing users of the Thrift compiler.
Do you have a particular scenario in mind, where this can break things? It is
behavior change, in the sense that the launch of the compiler does not
regenerate all of the target files. I assume this can be mentioned in the
release notes.
About the plug-ins: Do you have something like the Maven plug-in in mind? I
guess the question is, would this break plug-ins that rely on the thrift
compiler binary. I am thinking that it won't, but it is something to be
investigated. @mustafa-cosar Can you check if this behavior change would have
any impact on the maven thrift plugin?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Avoid updating Thrift compiler generated code if the output has not changed
> ---------------------------------------------------------------------------
>
> Key: THRIFT-4532
> URL: https://issues.apache.org/jira/browse/THRIFT-4532
> Project: Thrift
> Issue Type: Improvement
> Components: Compiler (General)
> Affects Versions: 0.11.0
> Reporter: Buğra Gedik
> Priority: Minor
> Fix For: 0.12.0
>
>
> We would like to contribute an improvement to the Thrift compiler that would
> avoid regenerating target file(s) if they are going to be exactly the same as
> the ones already present in the same place. This will help when running the
> Thrift compiler in our build, especially in recursive mode.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
