[
https://issues.apache.org/jira/browse/THRIFT-4569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471029#comment-16471029
]
ASF GitHub Bot commented on THRIFT-4569:
----------------------------------------
jfarrell closed pull request #1555: THRIFT-4569: Fix 'requiredness' typo
URL: https://github.com/apache/thrift/pull/1555
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/doc/specs/idl.md b/doc/specs/idl.md
index b7eb23cd57..dab04c7692 100644
--- a/doc/specs/idl.md
+++ b/doc/specs/idl.md
@@ -156,7 +156,7 @@ Most language implementations use the recommended pratice
of so-called "isset" f
- Read: Like optional, the field may, or may not be part of the input stream.
- Default values: may not be written (see next section)
-Default requiredess is a good starting point. The desired behaviour is a mix
of optional and required, hence the internal name "opt-in, req-out". Although
in theory these fields are supposed to be written ("req-out"), in reality unset
fields are not always written. This is especially the case, when the field
contains a <null> value, which by definition cannot be transported through
thrift. The only way to achieve this is by not writing that field at all, and
that's what most languages do.
+Default requiredness is a good starting point. The desired behaviour is a mix
of optional and required, hence the internal name "opt-in, req-out". Although
in theory these fields are supposed to be written ("req-out"), in reality unset
fields are not always written. This is especially the case, when the field
contains a <null> value, which by definition cannot be transported through
thrift. The only way to achieve this is by not writing that field at all, and
that's what most languages do.
#### Semantics of Default Values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Typo in field requiredness section of IDL docs
> ----------------------------------------------
>
> Key: THRIFT-4569
> URL: https://issues.apache.org/jira/browse/THRIFT-4569
> Project: Thrift
> Issue Type: Documentation
> Components: Documentation
> Reporter: Chad Knight
> Priority: Trivial
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
