[
https://issues.apache.org/jira/browse/THRIFT-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507240#comment-16507240
]
ASF GitHub Bot commented on THRIFT-4582:
----------------------------------------
jeking3 closed pull request #1563: THRIFT-4582: Fix Xenial CI build issues
URL: https://github.com/apache/thrift/pull/1563
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/.gitignore b/.gitignore
index be07a4ea5e..3de1595e6a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -122,8 +122,9 @@ project.lock.json
/lib/cpp/test/OptionalRequiredTest
/lib/cpp/test/SecurityTest
/lib/cpp/test/SpecializationTest
-/lib/cpp/test/ReflectionTest
/lib/cpp/test/RecursiveTest
+/lib/cpp/test/ReflectionTest
+/lib/cpp/test/RenderedDoubleConstantsTest
/lib/cpp/test/TFDTransportTest
/lib/cpp/test/TFileTransportTest
/lib/cpp/test/TInterruptTest
@@ -241,6 +242,7 @@ project.lock.json
/lib/php/src/ext/thrift_protocol/build/
/lib/php/src/ext/thrift_protocol/config.*
/lib/php/src/ext/thrift_protocol/configure
+/lib/php/src/ext/thrift_protocol/configure.ac
/lib/php/src/ext/thrift_protocol/configure.in
/lib/php/src/ext/thrift_protocol/install-sh
/lib/php/src/ext/thrift_protocol/libtool
diff --git a/LANGUAGES.md b/LANGUAGES.md
index ef3bee299f..d77496b4b9 100644
--- a/LANGUAGES.md
+++ b/LANGUAGES.md
@@ -101,7 +101,7 @@ The Language/Library Levels indicate the minimum and
maximum versions that are u
<td align=left><a href="lib/d/README.md">Dlang</a></td>
<!-- Since -----------------><td>0.9.0</td>
<!-- Build Systems ---------><td><img src="doc/images/cgrn.png"
alt="Yes"/></td><td><img src="doc/images/cred.png" alt=""/></td>
-<!-- Language Levels -------><td>2.073.2</td><td>2.080.0</td>
+<!-- Language Levels -------><td>2.075.1</td><td>2.080.0</td>
<!-- Low-Level Transports --><td><img src="doc/images/cred.png"
alt=""/></td><td><img src="doc/images/cgrn.png" alt="Yes"/></td><td><img
src="doc/images/cgrn.png" alt="Yes"/></td><td><img src="doc/images/cgrn.png"
alt="Yes"/></td><td><img src="doc/images/cgrn.png" alt="Yes"/></td><td><img
src="doc/images/cgrn.png" alt="Yes"/></td>
<!-- Transport Wrappers ----><td><img src="doc/images/cgrn.png"
alt="Yes"/></td><td><img src="doc/images/cgrn.png" alt="Yes"/></td><td><img
src="doc/images/cgrn.png" alt="Yes"/></td>
<!-- Protocols -------------><td><img src="doc/images/cgrn.png"
alt="Yes"/></td><td><img src="doc/images/cgrn.png" alt="Yes"/></td><td><img
src="doc/images/cgrn.png" alt="Yes"/></td><td><img src="doc/images/cred.png"
alt=""/></td>
diff --git a/build/docker/README.md b/build/docker/README.md
index 324921ead7..3d65a82ce3 100644
--- a/build/docker/README.md
+++ b/build/docker/README.md
@@ -143,7 +143,7 @@ Last updated: October 1, 2017
| c_glib | 2.48.2 | 2.54.0 | |
| cl (sbcl) | | 1.4.5 | |
| cocoa | | | Not in CI |
-| d | 2.073.2 | 2.080.0 | |
+| d | 2.075.1 | 2.080.0 | |
| dart | 1.22.1 | 1.24.3 | |
| delphi | | | Not in CI |
| dotnet | 2.1.4 | 2.1.4 | v2.1.4 SDK uses v2.0.5 Runtime |
diff --git a/build/docker/ubuntu-xenial/Dockerfile
b/build/docker/ubuntu-xenial/Dockerfile
index 760c501755..1e700029e9 100644
--- a/build/docker/ubuntu-xenial/Dockerfile
+++ b/build/docker/ubuntu-xenial/Dockerfile
@@ -13,7 +13,7 @@
#
# Apache Thrift Docker build environment for Ubuntu Xenial
# Using all stock Ubuntu Xenial packaging except for:
-# - d: does not come with Ubuntu so we're installing 2.073.2 for coverage
+# - d: does not come with Ubuntu so we're installing 2.075.1 for coverage
# - dart: does not come with Ubuntu so we're installing 1.22.1 for coverage
# - dotnet: does not come with Ubuntu
# - go: Xenial comes with 1.6, but we need 1.7 or later
@@ -45,7 +45,6 @@ RUN apt-get update && \
RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys EBCF975E5BA24D5E
&& \
wget http://master.dl.sourceforge.net/project/d-apt/files/d-apt.list -O
/etc/apt/sources.list.d/d-apt.list && \
wget -qO - https://dlang.org/d-keyring.gpg | apt-key add -
-ENV D_VERSION 2.073.2-0
# Dart
RUN curl https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add -
&& \
@@ -100,11 +99,12 @@ RUN apt-get install -y --no-install-recommends \
`# csharp (mono) dependencies` \
mono-devel
+ENV D_VERSION 2.075.1-0
RUN apt-get install -y --allow-unauthenticated --no-install-recommends \
`# D dependencies` \
dmd-bin=$D_VERSION \
libphobos2-dev=$D_VERSION \
- dub \
+ dub=1.6.0-0 \
dfmt \
dscanner \
libevent-dev \
diff --git a/lib/erl/rebar.test.config b/lib/erl/rebar.test.config
index 12515b7b56..2ff2afbb11 100644
--- a/lib/erl/rebar.test.config
+++ b/lib/erl/rebar.test.config
@@ -1,5 +1,5 @@
{erl_opts, [{platform_define, "^R.*", otp16_or_less}, debug_info]}.
{deps, [
- {meck, "", {git, "https://github.com/eproxus/meck.git";, {tag, "0.8.2"}}}
+ {meck, "", {git, "https://github.com/eproxus/meck.git";, {tag, "0.8.9"}}}
]}.
diff --git a/lib/rb/spec/server_spec.rb b/lib/rb/spec/server_spec.rb
index ee58c7cb4e..57f523776d 100644
--- a/lib/rb/spec/server_spec.rb
+++ b/lib/rb/spec/server_spec.rb
@@ -144,6 +144,7 @@
exception_q.push(StandardError.new('ERROR'))
end
expect { @server.rescuable_serve }.to(raise_error('ERROR'))
+ sleep(0.15)
end
it "should avoid running the server twice when retrying rescuable_serve" do
diff --git a/lib/rb/thrift.gemspec b/lib/rb/thrift.gemspec
index fcc344f48e..0f96c3fcc3 100644
--- a/lib/rb/thrift.gemspec
+++ b/lib/rb/thrift.gemspec
@@ -34,7 +34,7 @@ Gem::Specification.new do |s|
s.add_development_dependency 'rack', '~> 2.0'
s.add_development_dependency 'rack-test', '~> 0.8.3'
s.add_development_dependency 'rake', '~> 12.3'
- s.add_development_dependency 'rspec', '~> 3.5'
+ s.add_development_dependency 'rspec', '~> 3.7'
s.add_development_dependency 'thin', '~> 1.7'
end
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Ubuntu Xenial erlang 18.3 "make check" fails
> --------------------------------------------
>
> Key: THRIFT-4582
> URL: https://issues.apache.org/jira/browse/THRIFT-4582
> Project: Thrift
> Issue Type: Bug
> Components: Erlang - Library
> Affects Versions: 0.11.0
> Reporter: James E. King III
> Priority: Minor
>
> While running "make check" using the docker ubuntu-xenial image, the erlang
> unit tests are failing:
> {noformat}
> ii erlang-asn1
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP modules for
> ASN.1 support
> ii erlang-base
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP virtual machine
> and base applications
> ii erlang-crypto
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP cryptographic
> modules
> ii erlang-dev
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP development
> libraries and headers
> ii erlang-eunit
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP module for unit
> testing
> ii erlang-inets
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP Internet
> clients and servers
> ii erlang-mnesia
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP distributed
> relational/object hybrid database
> ii erlang-public-key
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP public key
> infrastructure
> ii erlang-runtime-tools
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP runtime
> tracing/debugging tools
> ii erlang-ssl
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP implementation
> of SSL
> ii erlang-syntax-tools
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP modules for
> handling abstract Erlang syntax trees
> ii erlang-tools
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP various tools
> ii erlang-webtool
> 1:18.3-dfsg-1ubuntu3.1 amd64 Erlang/OTP helper for
> web-based tools
> root@2785892e288b:/thrift/src/lib/erl# make check
> /usr/bin/rebar -C rebar.test.config get-deps
> ==> meck (get-deps)
> ==> erl (get-deps)
> /usr/bin/rebar -C rebar.test.config compile
> ==> meck (compile)
> ==> erl (compile)
> /usr/bin/rebar -C rebar.test.config skip_deps=true eunit
> ==> erl (eunit)
> in namespace_test()
> undefined
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> *** context setup failed ***
> **in function meck:new/2
> called as new(file,[unstick,passthrough])
> in call from test_thrift_file_transport:'-read_test_/0-fun-1-'/0
> (test/test_thrift_file_transport.erl, line 57)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> *** context setup failed ***
> **in function meck:new/2
> called as new(file,[unstick,passthrough])
> in call from test_thrift_file_transport:'-read_exact_test_/0-fun-1-'/0
> (test/test_thrift_file_transport.erl, line 102)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> *** context setup failed ***
> **in function meck:new/2
> called as new(file,[unstick,passthrough])
> in call from test_thrift_file_transport:'-write_test_/0-fun-1-'/0
> (test/test_thrift_file_transport.erl, line 147)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> *** context setup failed ***
> **in function meck:new/2
> called as new(file,[unstick,passthrough])
> in call from test_thrift_file_transport:'-flush_test_/0-fun-1-'/0
> (test/test_thrift_file_transport.erl, line 185)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> *** context setup failed ***
> **in function meck:new/2
> called as new(file,[unstick,passthrough])
> in call from test_thrift_file_transport:'-close_test_/0-fun-1-'/0
> (test/test_thrift_file_transport.erl, line 203)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> *** context setup failed ***
> **in function meck:new/2
> called as new(gen_tcp,[unstick,passthrough])
> in call from test_thrift_socket_transport:'-read_test_/0-fun-1-'/0
> (test/test_thrift_socket_transport.erl, line 53)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> *** context setup failed ***
> **in function meck:new/2
> called as new(gen_tcp,[unstick,passthrough])
> in call from test_thrift_socket_transport:'-read_exact_test_/0-fun-2-'/0
> (test/test_thrift_socket_transport.erl, line 99)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> *** context setup failed ***
> **in function meck:new/2
> called as new(gen_tcp,[unstick,passthrough])
> in call from test_thrift_socket_transport:'-write_test_/0-fun-1-'/0
> (test/test_thrift_socket_transport.erl, line 148)
> **error:undef
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> beam/beam_load.c(1189): Error loading module meck:
> mandatory chunk of type 'Atom' not found
> =ERROR REPORT==== 9-Jun-2018::03:12:08 ===
> Loading of /thrift/src/lib/erl/deps/meck/ebin/meck.beam failed: badfile
> undefined
> *** context setup failed ***
> **in function meck:new/2
> called as new(gen_tcp,[unstick,passthrough])
> in call from test_thrift_socket_transport:'-close_test_/0-fun-1-'/0
> (test/test_thrift_socket_transport.erl, line 189)
> **error:undef
> =INFO REPORT==== 9-Jun-2018::03:12:09 ===
> thrift_disk_log_transport syncing
> =INFO REPORT==== 9-Jun-2018::03:12:09 ===
> thrift_disk_log_transport syncing
> =INFO REPORT==== 9-Jun-2018::03:12:09 ===
> thrift service listening on port 9090
> =ERROR REPORT==== 9-Jun-2018::03:12:10 ===
> {thrift_socket_server,282,
> {child_error,normal,
> <<"Program counter: 0x00007fe20c043ef0
> (unknown function)\nCP: 0x00007fe20bb5c180 (thrift_socket_server:terminate/2
> + 216)\n\n0x00007fe202906a68 Return addr 0x00007fe20c486140
> (gen_server:try_terminate/3 + 136)\ny(0) normal\ny(1)
> 9090\n\n0x00007fe202906a80 Return addr 0x00007fe20c488be8
> (gen_server:terminate/7 + 152)\ny(0) Catch 0x00007fe20c4861a0
> (gen_server:try_terminate/3 + 232)\n\n0x00007fe202906a90 Return addr
> 0x00007fe20c463a80 (proc_lib:init_p_do_apply/3 + 56)\ny(0) []\ny(1)
> {thrift_socket_server,9090,[{\"Multiplexing_Calculator\",multiplexing__calculator_thrift},{\"Multiplexing_WeatherReport\",multiplexing__weather_report_thrift}],[{\"Multiplexing_Calculator\",multiplexing_test},{\"Multiplexing_WeatherReport\",multiplexing_test},{\"error_handler\",multiplexing_test}],{local,multiplexing_test},2047,{127,0,0,1},#Port<0.37513>,<0.335.0>,[{recv_timeout,500}],binary,false,false,[]}\ny(2)
> thrift_socket_server\ny(3) {'$gen_cast',stop}\ny(4)
> multiplexing_test\ny(5) normal\ny(6) normal\n\n0x00007fe202906ad0
> Return addr 0x000000000088b9a8 (<terminate process normally>)\ny(0) Catch
> 0x00007fe20c463aa0 (proc_lib:init_p_do_apply/3 + 88)\n">>}}
> =======================================================
> Failed: 0. Skipped: 0. Passed: 278.
> One or more tests were cancelled.
> ERROR: One or more eunit tests failed.
> ERROR: eunit failed while processing /thrift/src/lib/erl: rebar_abort
> Makefile:663: recipe for target 'check' failed
> make: *** [check] Error 1
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
