[ https://issues.apache.org/jira/browse/THRIFT-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507387#comment-16507387 ]
Kashirin Alex commented on THRIFT-4584: --------------------------------------- You remind me to do the Thrift make test. It is the test for Thrift 0.11.0 [http://archive.apache.org/dist/thrift/0.11.0/thrift-0.11.0.tar.gz] built with gcc-8.1.0 and, for info, gcc was built as follow [https://github.com/kashirin-alex/environments-builder/blob/master/scripts/gcc.sh] The results are bad (I did not continue to rest of the tests, TNonblockingServerTest as well Timed-out). * Start 4: TServerIntegrationTest 4/45 Test #4: TServerIntegrationTest ...........***Exception: Child aborted 0.02 sec * Start 12: AllProtocolsTest 12/45 Test #12: AllProtocolsTest .................***Failed 0.00 sec * Start 20: processor_test 20/45 Test #20: processor_test ...................***Timeout 1500.11 sec Executions of tests directly: TServerIntegrationTest {code} root@dev-2 ~/builds/builts/thrift # ./bin/TServerIntegrationTest Running 13 test cases... Thrift: Sun Jun 10 15:07:58 2018 received invalid message type 0 from client unknown location(0): fatal error: in "constructors/test_simple_factory": apache::thrift::transport::TTransportException: No more data to read. /root/builds/sources/thrift/lib/cpp/test/TServerIntegrationTest.cpp(350): last checkpoint: "test_simple_factory" test entry Thrift: Sun Jun 10 15:07:58 2018 received invalid message type 0 from client unknown location(0): fatal error: in "constructors/test_simple": apache::thrift::transport::TTransportException: No more data to read. /root/builds/sources/thrift/lib/cpp/test/TServerIntegrationTest.cpp(354): last checkpoint: "test_simple" test entry Thrift: Sun Jun 10 15:07:58 2018 received invalid message type 0 from client unknown location(0): fatal error: in "constructors/test_threaded_factory": apache::thrift::transport::TTransportException: No more data to read. /root/builds/sources/thrift/lib/cpp/test/TServerIntegrationTest.cpp(359): last checkpoint: "test_threaded_factory" test entry Thrift: Sun Jun 10 15:07:58 2018 received invalid message type 0 from client unknown location(0): fatal error: in "constructors/test_threaded": apache::thrift::transport::TTransportException: No more data to read. /root/builds/sources/thrift/lib/cpp/test/TServerIntegrationTest.cpp(363): last checkpoint: "test_threaded" test entry Thrift: Sun Jun 10 15:07:58 2018 received invalid message type 0 from client unknown location(0): fatal error: in "constructors/test_threaded_bound": apache::thrift::transport::TTransportException: No more data to read. /root/builds/sources/thrift/lib/cpp/test/TServerIntegrationTest.cpp(368): last checkpoint: "test_threaded_bound" test entry Thrift: Sun Jun 10 15:07:58 2018 received invalid message type 0 from client terminate called after throwing an instance of 'apache::thrift::transport::TTransportException' what(): No more data to read. Thrift: Sun Jun 10 15:07:58 2018 received invalid message type 0 from client terminate called recursively unknown location(0): fatal error: in "constructors/test_threaded_stress": signal: SIGABRT (application abort requested) /root/builds/sources/thrift/lib/cpp/test/TServerIntegrationTest.cpp(374): last checkpoint: "test_threaded_stress" test entry Aborted {code} AllProtocolsTest {code} root@dev-2 ~/builds/builts/thrift # ./bin/AllProtocolsTest Running 3 test cases... unknown location(0): fatal error: in "test_binary_protocol": apache::thrift::TException: TBinaryProtocol => Test FAILED: readMessageBegin failed. /root/builds/sources/thrift/lib/cpp/test/AllProtocolTests.cpp(37): last checkpoint: "test_binary_protocol" test entry unknown location(0): fatal error: in "test_little_binary_protocol": apache::thrift::TException: TLEBinaryProtocol => Test FAILED: readMessageBegin failed. /root/builds/sources/thrift/lib/cpp/test/AllProtocolTests.cpp(41): last checkpoint: "test_little_binary_protocol" test entry TCompactProtocol => OK *** 2 failures are detected in the test module "AllProtocolTests" {code} processor_test {code} root@dev-2 ~/builds/builts/thrift # builds/builts/thrift./bin/processor_test &> processor_test_output.txt {code} [^processor_test_output.txt] while, a built of Thrift 0.11.0 with gcc-7.3.0 is Good (just, some different issues with the Python,Java env. for some specific py and java tests) Thank You. > runtime issues with a ThriftBroker/server built with GCC8 > --------------------------------------------------------- > > Key: THRIFT-4584 > URL: https://issues.apache.org/jira/browse/THRIFT-4584 > Project: Thrift > Issue Type: Bug > Components: C++ - Library > Affects Versions: 0.10.0, 0.11.0 > Environment: OS Ubuntu 18.04, > [Dev.Env.|https://github.com/kashirin-alex/environments-builder/blob/master/build-env.sh] > with GCC 8.1.0 > > Reporter: Kashirin Alex > Assignee: James E. King III > Priority: Critical > Attachments: processor_test_output.txt > > > issues coming from a compilation made with GCC 8.1.0 while a build with GCC > 7.3 is passing all the tests. > Main subject in question, Are there any familiar issue/requirement to > compile with GCC 8.1.0 ? > The tests are: > [https://github.com/kashirin-alex/hypertable/blob/master/src/cc/ThriftBroker/tests/client_test.cc] > The source of ThriftBroker/Server is at > [https://github.com/kashirin-alex/hypertable/blob/master/src/cc/ThriftBroker/ThriftBroker.cc#L3156] > There are no issues with ThriftBroker accepts and closes clients connections. > while there is an error of "received invalid message type 0 from client" > that happens with the initial T_CALL and looks like the issue is surrounding > the read from client > [https://github.com/apache/thrift/blob/master/lib/cpp/src/thrift/TDispatchProcessor.h#L76] > and it is for probably all the initial fname call > by the source of gen-cpp at > [https://github.com/kashirin-alex/hypertable/tree/master/src/cc/ThriftBroker/thrift-0.11.0/gen-cpp], > generated by > [https://github.com/kashirin-alex/hypertable/blob/master/src/cc/ThriftBroker/Hql.thrift] > in this error case it is for the following client call > "client->generate_guid(String)" > for the header of > [https://github.com/kashirin-alex/hypertable/blob/master/src/cc/ThriftBroker/thrift-0.11.0/gen-cpp/ClientService.h#L887] > source at > [https://raw.githubusercontent.com/kashirin-alex/hypertable/master/src/cc/ThriftBroker/thrift-0.11.0/gen-cpp/ClientService.cpp] > to look for: "void ClientServiceClient::send_generate_guid()" > Linking CXX executable htThriftBroker > {code} > cd /root/builds/builts/hypertable/src/cc/ThriftBroker && /usr/local/bin/cmake > -E cmake_link_script CMakeFiles/htThriftBroker.dir/link.txt --verbose=1 > /usr/local/bin/c++ -DHAVE_NETINET_IN_H -Wno-long-long -Wall > -Wno-unknown-pragmas -pedantic -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 > -m64 -D_REENTRANT -fPIC -std=c++17 -U__STRICT_ANSI__ -Wno-terminate -O3 -flto > -fuse-linker-plugin -ffat-lto-objects -floop-interchange -DTCMALLOC_MINIMAL > -DHT_WITH_THRIFT -Wno-variadic-macros -O3 -DNDEBUG -rdynamic > CMakeFiles/htThriftBroker.dir/ThriftBroker.cc.o > CMakeFiles/htThriftBroker.dir/MetricsHandler.cc.o -o htThriftBroker > libHyperThriftConfig.a ../HyperAppHelper/libHyperAppHelper.a libHyperThrift.a > -Wl,--whole-archive /usr/local/lib/libthrift.a /usr/local/lib/libthriftnb.a > /usr/local/lib/libthriftz.a /usr/local/lib/libevent.a /usr/local/lib/libssl.a > -Wl,--no-whole-archive ../Hypertable/Lib/libHypertable.a -lm > -Wl,--whole-archive /usr/local/lib/libsnappy.a /usr/local/lib/libexpat.a > -Wl,--no-whole-archive ../Hyperspace/libHyperspace.a > ../Tools/Lib/libHyperTools.a -Wl,--whole-archive /usr/local/lib/libedit.a > -Wl,--no-whole-archive ../FsBroker/Lib/libHyperFsBroker.a > ../AsyncComm/libHyperComm.a ../Common/libHyperCommon.a -lpthread -ldl > -Wl,--whole-archive /usr/local/lib/libtcmalloc_minimal.a > /usr/local/lib/libboost_system.a /usr/local/lib/libboost_filesystem.a > /usr/local/lib/libboost_iostreams.a /usr/local/lib/libboost_program_options.a > /usr/local/lib/libboost_thread.a /usr/local/lib/libboost_chrono.a > /usr/local/lib/libz.a /usr/local/lib/libbz2.a /usr/local/lib/liblzma.a > /usr/local/lib/libncursesw.a /usr/local/lib/libre2.a > /usr/local/lib/libcrypto.a -Wl,--no-whole-archive > ../ThirdParty/libHyperThirdParty.a -static-libgcc -static-libstdc++ > {code} > It can be great to have suggestions on reasons for the issue at runtime for a > build with GCC8 > and considering GCC 8.1.0 changes for strictness for casting, Are there any > issues in progress (I could not find any related to GCC 8.1.0) ? > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)