[ 
https://issues.apache.org/jira/browse/THRIFT-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16525478#comment-16525478
 ] 

ASF GitHub Bot commented on THRIFT-4551:
----------------------------------------

NameFILIP commented on issue #1548: THRIFT-4551: Run 'yarn prettier' to 
consistently format JS files
URL: https://github.com/apache/thrift/pull/1548#issuecomment-400796255
 
 
   yes, it conflicts with jslint rules.. which is not very flexible. Ideally, 
the project should be changed to use eslint which is much more powerful and is 
the industry standard and it should be good then.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add prettier for consistent JS code formatting
> ----------------------------------------------
>
>                 Key: THRIFT-4551
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4551
>             Project: Thrift
>          Issue Type: Improvement
>            Reporter: Filip Spiridonov
>            Assignee: James E. King III
>            Priority: Minor
>             Fix For: 0.12.0
>
>
> [Prettier|https://prettier.io/] is awesome. See 
> [why|https://prettier.io/docs/en/why-prettier.html] you should use it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to